-
-
Notifications
You must be signed in to change notification settings - Fork 197
Fix broken prepare platform on NPM 5.5.1 #3218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken prepare platform on NPM 5.5.1 #3218
Conversation
…ssed by userSpecifiedPackageName) (NativeScript#3217)
Can one of the admins verify this patch? |
run ci |
Can one of the admins verify this patch? |
Hey @buuhuu , We'll see which solution covers all scenarios and we'll decide which PR to merge. |
Your are right, this is exactly the same and i think, without checking my project, this will resolve my issue as well. Though I don’t see the need of the split by @ nor the need of using _ for that in #3213. The split should not be necessary as the parameter, from its name, is not a package descriptor but a package name. The find can be done as shown in this PR. |
Hey @buuhuu ,
The other scenario where the
In these cases we still have to default to something (as done in the other PR). I've also checked the failing tests in both PRs (sorry you are unable to see them, we will do some work to show the results in the PR itself in the future) - we have some integration tests that install runtime packages with So I'm going to close this one and continue checking the other PR. Thanks again for taking your time to create this PR, we really appreciate it and we'll be glad to assist you further in your next contributions to NativeScript! |
Closing in favor of #3213 |
Thanks for the explanation, that completely makes sense. |
Instead of taking the first updated dependency, we resolve the one passed by userSpecifiedPackageName) (#3217)